New property to indicate an interchange within the same vehicle#1027
Merged
Conversation
Contributor
|
I think this PR is useful, because:
|
ue71603
previously approved these changes
May 23, 2026
skinkie
previously approved these changes
May 23, 2026
trurlurl
previously approved these changes
May 25, 2026
Contributor
|
@thbar @TuThoThai can somebody outside of the people that have already discussed this also check this PR and approve it? So that we can merge it? |
Contributor
|
@thbar ready to merge. Or should I do it? |
Contributor
|
@ue71603 I will be able to respond fully next week, but not this one. |
Adding the tag `+v2.1` in the documentation of the added element
TuThoThai
approved these changes
Jul 16, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where trains split for different final destinations, this can be modelled as two (or more) ServiceJourneys with a ServiceJourneyInterchange. A passenger may remain seated if he/she entered the correct train part in the first place. Setting "StaySeated" true seems to be somwhat unsafe in this situation, as the passenger may end up in the wrong destination. We therefore propose to introduce a new Element "ChangeWithinVehicle" in InterchangePropertiesGroup. If set to true, the passenger may have to change within the vehicle.